Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_databricks_access_connector : support SystemAssigned, UserAssigned identity type #28442

Merged
merged 1 commit into from
Jan 8, 2025
Merged

azurerm_databricks_access_connector : support SystemAssigned, UserAssigned identity type #28442

merged 1 commit into from
Jan 8, 2025

Conversation

sinbai
Copy link
Contributor

@sinbai sinbai commented Jan 8, 2025

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

Support SystemAssigned, UserAssigned identity type

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

  • I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
  • I have written new tests for my resource or datasource changes & updated any relevent documentation.
  • I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
  • (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

PASS: TestAccDatabricksAccessConnector_identityComplete (461.69s)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Fixes #26062

@sinbai sinbai requested a review from a team as a code owner January 8, 2025 03:45
@sinbai sinbai mentioned this pull request Jan 8, 2025
Closed
1 task
stephybun
stephybun approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sinbai LGTM 👍

@stephybun stephybun merged commit c94d4bf into hashicorp:main Jan 8, 2025
34 checks passed
@github-actions github-actions bot added this to the v4.15.0 milestone Jan 8, 2025
stephybun added a commit that referenced this pull request Jan 9, 2025
@stephybun
Update for #28360 #28216 #27830 #28404 #27401 #27122 #27931 #28442
734560f
jackofallops pushed a commit that referenced this pull request Jan 10, 2025
@stephybun @jackofallops
Update for #28360 #28216 #27830 #28404 #27401 #27122 #27931 #28442
ec55afd
jackofallops added a commit that referenced this pull request Jan 10, 2025
@jackofallops @stephybun
@catriona-m @wyattfry @sreallymatt @mbfrahry @katbyte
CHANGELOG for v4.15.0 release (#28276)
1756d4c 
* Update CHANGELOG.md for #28233

* Update for #28215

* Update CHANGELOG.md for #28279

* Update CHANGELOG.md #28269

* Update CHANGELOG.md #27876

* Update CHANGELOG.md #28069

* Update CHANGELOG.md for #28312

* Update CHANGELOG.md for #28278

* Update CHANGELOG.md #28311

* Update CHANGELOG.md undo 28311

* Update CHANGELOG.md #27874

* Update CHANGELOG.md

* Update CHANGELOG for #28352

* Update CHANGELOG.md for #28390

* Update CHANGELOG.md for #28398

* Update CHANGELOG.md for #28425

* Update CHANGELOG.md #28427

* Update CHANGELOG.md #28280

* Update CHANGELOG.md for #28319

* Update CHANGELOG.md #24801

* Update for #28360 #28216 #27830 #28404 #27401 #27122 #27931 #28442

* Update for #28379

* Update CHANGELOG.md for #28281

* Update for #28380

* Update for #27375

* Update for #25695

* Update CHANGELOG.md #27985

* Update CHANGELOG.md - update release date manually until can be scripted

* Update CHANGELOG.md revert date change as script available

* pre-release script updates

---------

Co-authored-by: stephybun <steph@hashicorp.com>
Co-authored-by: catriona-m <86247157+catriona-m@users.noreply.github.com>
Co-authored-by: Wyatt Fry <wyattfry@gmail.com>
Co-authored-by: sreallymatt <106555974+sreallymatt@users.noreply.github.com>
Co-authored-by: Matthew Frahry <mbfrahry@gmail.com>
Co-authored-by: kt <kt@katbyte.me>
NotTheEvilOne pushed a commit to b1-systems/terraform-provider-azurerm that referenced this pull request Jan 20, 2025
@sinbai @NotTheEvilOne
support identity (hashicorp#28442)
8ff9dbd
NotTheEvilOne pushed a commit to b1-systems/terraform-provider-azurerm that referenced this pull request Jan 20, 2025
@jackofallops @stephybun
@catriona-m @wyattfry @sreallymatt @mbfrahry @katbyte @NotTheEvilOne
CHANGELOG for v4.15.0 release (hashicorp#28276)
c351fd6 
* Update CHANGELOG.md for hashicorp#28233

* Update for hashicorp#28215

* Update CHANGELOG.md for hashicorp#28279

* Update CHANGELOG.md hashicorp#28269

* Update CHANGELOG.md hashicorp#27876

* Update CHANGELOG.md hashicorp#28069

* Update CHANGELOG.md for hashicorp#28312

* Update CHANGELOG.md for hashicorp#28278

* Update CHANGELOG.md hashicorp#28311

* Update CHANGELOG.md undo 28311

* Update CHANGELOG.md hashicorp#27874

* Update CHANGELOG.md

* Update CHANGELOG for hashicorp#28352

* Update CHANGELOG.md for hashicorp#28390

* Update CHANGELOG.md for hashicorp#28398

* Update CHANGELOG.md for hashicorp#28425

* Update CHANGELOG.md hashicorp#28427

* Update CHANGELOG.md hashicorp#28280

* Update CHANGELOG.md for hashicorp#28319

* Update CHANGELOG.md hashicorp#24801

* Update for hashicorp#28360 hashicorp#28216 hashicorp#27830 hashicorp#28404 hashicorp#27401 hashicorp#27122 hashicorp#27931 hashicorp#28442

* Update for hashicorp#28379

* Update CHANGELOG.md for hashicorp#28281

* Update for hashicorp#28380

* Update for hashicorp#27375

* Update for hashicorp#25695

* Update CHANGELOG.md hashicorp#27985

* Update CHANGELOG.md - update release date manually until can be scripted

* Update CHANGELOG.md revert date change as script available

* pre-release script updates

---------

Co-authored-by: stephybun <steph@hashicorp.com>
Co-authored-by: catriona-m <86247157+catriona-m@users.noreply.github.com>
Co-authored-by: Wyatt Fry <wyattfry@gmail.com>
Co-authored-by: sreallymatt <106555974+sreallymatt@users.noreply.github.com>
Co-authored-by: Matthew Frahry <mbfrahry@gmail.com>
Co-authored-by: kt <kt@katbyte.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephybun stephybun stephybun approved these changes

Assignees
No one assigned
Labels
documentation enhancement service/databricks size/S
Projects
None yet
Milestone
v4.15.0
2 participants
@sinbai @stephybun